[Intl] Add NumberFormatter::ROUND_HALFODD
#13191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayesh
force-pushed
the
intl-numberformatter-halfodd
branch
from
67e8ed5 to
73883c2
Compare
jorgsowa
reviewed
Jan 18, 2024
The NumberFormatter::ROUND_HALFEVEN constant exists in PHP already, but its counterpart ROUND_HALFODD was missing. This adds it, using `UNUM_ROUND_HALF_ODD`
Ayesh
force-pushed
the
intl-numberformatter-halfodd
branch
from
73883c2 to
b0a421e
Compare
|
Thank you 🙏. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NumberFormatter::ROUND_HALFEVENconstant exists in PHP already, but its counterpartROUND_HALFODDwas missing. This adds it, usingUNUM_ROUND_HALF_ODD.